Re: [PATCh v3 04/14] ASoC: rsnd: Add RZ/G3E SoC probing and register map

[Kuninori Morimoto]

Hi John, Mark

Thank you for the patch

> > @@ -629,7 +632,9 @@ struct rsnd_priv {
> >  #define RSND_GEN4	(4 << 0)
> >  #define RSND_SOC_MASK	(0xFF << 4)
> >  #define RSND_SOC_E	(1 << 4) /* E1/E2/E3 */
> > -
> > +#define RSND_RZ_MASK	(0xFF << 8)
> 
> This overlaps with RSND_SOC_MASK.  That might be intentional but I'm
> really not sure and it's all kind of unclear.

Indeed.
But it seems the strange is RSND_SOC_MASK, it should be

	- #define RSND_SOC_MASK	(0xFF << 4)
	+ #define RSND_SOC_MASK	(0xF  << 4)

I think it is good timing to have comment to clarify flag.

	0x....DCBA
	A:	R-Car GenX
	B:	R-Car GenX identifier (if needed)
	C:	RZ series
	D:	RZ series  identifier (if needed)

Thank you for your help !!

Best regards
---
Kuninori Morimoto