arch/riscv/kernel/signal.c:133:15: sparse: sparse: incorrect type in assignment (different address spaces)
From: kernel test robot
Date: Fri Apr 03 2026 - 04:43:10 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9147566d801602c9e7fc7f85e989735735bf38ba
commit: 818d78ba1b3f88d2bfee249f25020211488a26c3 riscv: signal: abstract header saving for setup_sigcontext
date: 3 months ago
config: riscv-randconfig-r131-20260402 (https://download.01.org/0day-ci/archive/20260403/202604030009.T0N2kopM-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 14.3.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260403/202604030009.T0N2kopM-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 818d78ba1b3f ("riscv: signal: abstract header saving for setup_sigcontext")
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604030009.T0N2kopM-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> arch/riscv/kernel/signal.c:133:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:133:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:133:15: sparse: got void *
>> arch/riscv/kernel/signal.c:133:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:133:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:133:15: sparse: got void *
>> arch/riscv/kernel/signal.c:133:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:133:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:133:15: sparse: got void *
>> arch/riscv/kernel/signal.c:133:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:133:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:133:15: sparse: got void *
arch/riscv/kernel/signal.c:148:22: sparse: sparse: symbol 'arch_ext_list' was not declared. Should it be static?
arch/riscv/kernel/signal.c:155:14: sparse: sparse: symbol 'nr_arch_exts' was not declared. Should it be static?
arch/riscv/kernel/signal.c:300:39: sparse: sparse: cast removes address space '__user' of expression
arch/riscv/kernel/signal.c:300:36: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct __riscv_ctx_hdr [noderef] __user *sc_ext_ptr @@ got void * @@
arch/riscv/kernel/signal.c:300:36: sparse: expected struct __riscv_ctx_hdr [noderef] __user *sc_ext_ptr
arch/riscv/kernel/signal.c:300:36: sparse: got void *
vim +133 arch/riscv/kernel/signal.c
8ee0b41898fa26 Greentime Hu 2023-06-05 107
8ee0b41898fa26 Greentime Hu 2023-06-05 108 /*
8ee0b41898fa26 Greentime Hu 2023-06-05 109 * Restore Vector extension context from the user's signal frame. This function
8ee0b41898fa26 Greentime Hu 2023-06-05 110 * assumes a valid extension header. So magic and size checking must be done by
8ee0b41898fa26 Greentime Hu 2023-06-05 111 * the caller.
8ee0b41898fa26 Greentime Hu 2023-06-05 112 */
8ee0b41898fa26 Greentime Hu 2023-06-05 113 static long __restore_v_state(struct pt_regs *regs, void __user *sc_vec)
8ee0b41898fa26 Greentime Hu 2023-06-05 114 {
8ee0b41898fa26 Greentime Hu 2023-06-05 115 long err;
8ee0b41898fa26 Greentime Hu 2023-06-05 116 struct __sc_riscv_v_state __user *state = sc_vec;
8ee0b41898fa26 Greentime Hu 2023-06-05 117 void __user *datap;
8ee0b41898fa26 Greentime Hu 2023-06-05 118
c27fa53b858b4e Björn Töpel 2024-04-03 119 /*
c27fa53b858b4e Björn Töpel 2024-04-03 120 * Mark the vstate as clean prior performing the actual copy,
c27fa53b858b4e Björn Töpel 2024-04-03 121 * to avoid getting the vstate incorrectly clobbered by the
c27fa53b858b4e Björn Töpel 2024-04-03 122 * discarded vector state.
c27fa53b858b4e Björn Töpel 2024-04-03 123 */
c27fa53b858b4e Björn Töpel 2024-04-03 124 riscv_v_vstate_set_restore(current, regs);
c27fa53b858b4e Björn Töpel 2024-04-03 125
8ee0b41898fa26 Greentime Hu 2023-06-05 126 /* Copy everything of __sc_riscv_v_state except datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 127 err = __copy_from_user(¤t->thread.vstate, &state->v_state,
8ee0b41898fa26 Greentime Hu 2023-06-05 128 offsetof(struct __riscv_v_ext_state, datap));
8ee0b41898fa26 Greentime Hu 2023-06-05 129 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 130 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 131
8ee0b41898fa26 Greentime Hu 2023-06-05 132 /* Copy the pointer datap itself. */
8ee0b41898fa26 Greentime Hu 2023-06-05 @133 err = __get_user(datap, &state->v_state.datap);
8ee0b41898fa26 Greentime Hu 2023-06-05 134 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 135 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 136 /*
8ee0b41898fa26 Greentime Hu 2023-06-05 137 * Copy the whole vector content from user space datap. Use
8ee0b41898fa26 Greentime Hu 2023-06-05 138 * copy_from_user to prevent information leak.
8ee0b41898fa26 Greentime Hu 2023-06-05 139 */
c27fa53b858b4e Björn Töpel 2024-04-03 140 return copy_from_user(current->thread.vstate.datap, datap, riscv_v_vsize);
8ee0b41898fa26 Greentime Hu 2023-06-05 141 }
818d78ba1b3f88 Andy Chiu 2025-11-12 142
:::::: The code at line 133 was first introduced by commit
:::::: 8ee0b41898fa26f66e32237f179b6989c65600d6 riscv: signal: Add sigcontext save/restore for vector
:::::: TO: Greentime Hu <greentime.hu@xxxxxxxxxx>
:::::: CC: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki