Re: [PATCH v5 3/3] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2
From: Chukun Pan
Date: Fri Apr 03 2026 - 06:04:02 EST
Hi,
> + pcie_vcc_3v3: regulator-pcie-vcc3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "pcie_vcc3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
I would like to maintain the same property order as the
regulator below, and add vin-supply:
```
pcie_vcc3v3: pcie-vcc3v3 {
compatible = "regulator-fixed";
enable-active-high;
gpios = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
regulator-name = "pcie_vcc3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
vin-supply = <&vcc_5v0>;
};
```
> +&pcie1 {
> + vpcie3v3-supply = <&pcie_vcc_3v3>;
> +&pcie2 {
> + vpcie3v3-supply = <&pcie_vcc_3v3>;
I think vpcie3v3-supply is not needed here. [1]
> + hub_2_0: hub@1 {
> + compatible = "usb5e3,610";
> + reg = <0x1>;
> + peer-hub = <&hub_3_0>;
> + vdd-supply = <&vcc5v0_usb30>;
vdd-supply = <&vcc_5v0>;
Please refer to the schematic. [2]
[1] https://lore.kernel.org/linux-pci/u53qfrubgrcamiz35ox6lcdpp5bbzfwcsic466z5r6yyx6xz3n@c64nw2pegtfe/
[2] https://drive.google.com/drive/folders/1pcI_U0C3VJKTCg8A1zj08CwNbohnONSR
Thanks,
Chukun