Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Fix ICE reg size

From: Harshal Dev

Date: Fri Apr 03 2026 - 13:04:26 EST




On 4/2/2026 12:05 AM, Kuldeep Singh wrote:
> The ICE register region on Kodiak is currently defined as 0x8000 bytes.
> According to the hardware specification, the correct register size is
> 0x18000.
>
> Update the ICE node reg property to match the hardware.
>
> Fixes: dfd5ee7b34bb ("arm64: dts: qcom: sc7280: Add inline crypto engine")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index 6079e67ea829..ed8361f79e28 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -2578,7 +2578,7 @@ ufs_mem_phy: phy@1d87000 {
> ice: crypto@1d88000 {
> compatible = "qcom,sc7280-inline-crypto-engine",
> "qcom,inline-crypto-engine";
> - reg = <0 0x01d88000 0 0x8000>;
> + reg = <0 0x01d88000 0 0x18000>;
> clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
> };
>
>

Good catch, looks good to me.

Reviewed-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>

Regards,
Harshal