RE: [PATCh v3 07/14] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF support

[John Madieu]

Hi Mark,

Thanks for your review.

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Thursday, April 2, 2026 7:54 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCh v3 07/14] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF
> support
> 
> On Thu, Apr 02, 2026 at 06:24:29PM +0200, John Madieu wrote:
> 
> > Rather than scattering SoC-specific checks across functional code,
> > introduce an extra capability flags in the match data:
> 
> >  bool rsnd_ssiu_busif_err_status_clear(struct rsnd_mod *mod)  {
> > +	struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
> 
> There's a priv already in the if (status) check in the loop in this
> function.

Right. I'll remove it in v4.

> 
> > @@ -160,7 +161,8 @@ static int rsnd_ssiu_init(struct rsnd_mod *mod,
> >  	/*
> >  	 * SSI_MODE0
> >  	 */
> > -	rsnd_mod_bset(mod, SSI_MODE0, (1 << id), !use_busif << id);
> > +	if (!rsnd_is_rzg3e(priv))
> > +		rsnd_mod_bset(mod, SSI_MODE0, (1 << id), !use_busif << id);
> 
> Perhaps should be a capability flag like the changelog said?

I'll update the changelog to accurately describe things.

> 
> > +	/* Acquire shared reset once for all SSIU modules */
> > +	rstc = devm_reset_control_get_optional_shared(dev, "ssi-all");
> > +	if (IS_ERR(rstc))
> > +		rstc = NULL;
> 
> This just ignores actual errors, including -EPROBE_DEFER.  I would expect
> us to report all errors as normal, the reset API will already return NULL
> for genuinely absent resets.

Indeed. I'll properly propagate the error via dev_err_probe() instead.

Regards,
John