RE: [PATCh v3 14/14] ASoC: rsnd: Add system suspend/resume support

[John Madieu]

Hi Kuninori,

Thanks for your review.

> -----Original Message-----
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> Sent: Friday, April 3, 2026 3:53 AM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCh v3 14/14] ASoC: rsnd: Add system suspend/resume
> support
> 
> 
> Hi John
> 
> > Add per-module suspend/resume functions following the existing driver
> > architecture where each module manages its own resources in its own
> > file. core.c provides common clock/reset helpers and orchestrates the
> > calls in the correct order (reverse probe for suspend, probe order for
> > resume).
> >
> > Infrastructure clocks (ADG, audmacpp, SCU) are managed globally using
> > optional APIs to remain transparent to platforms that don't specify
> > these clocks/resets.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > ---
> (snip)
> > +/* Per-module suspend/resume */
> > +void rsnd_ssi_suspend(struct rsnd_priv *priv); void
> > +rsnd_ssi_resume(struct rsnd_priv *priv); void
> > +rsnd_ssiu_suspend(struct rsnd_priv *priv); void
> > +rsnd_ssiu_resume(struct rsnd_priv *priv); void
> > +rsnd_src_suspend(struct rsnd_priv *priv); void rsnd_src_resume(struct
> > +rsnd_priv *priv); void rsnd_ctu_suspend(struct rsnd_priv *priv); void
> > +rsnd_ctu_resume(struct rsnd_priv *priv); void rsnd_mix_suspend(struct
> > +rsnd_priv *priv); void rsnd_mix_resume(struct rsnd_priv *priv); void
> > +rsnd_dvc_suspend(struct rsnd_priv *priv); void rsnd_dvc_resume(struct
> > +rsnd_priv *priv); void rsnd_adg_suspend(struct rsnd_priv *priv); void
> > +rsnd_adg_resume(struct rsnd_priv *priv); void rsnd_dma_suspend(struct
> > +rsnd_priv *priv); void rsnd_dma_resume(struct rsnd_priv *priv);
> 
> rsnd.h is categorizing definition for each IPs.
> Please merge above into existing area.

Agreed. I'll distribute each suspend/resume declaration into its respective
section following the probe/remove pattern.

Regards,
John

> 
> Thank you for your help !!
> 
> Best regards
> ---
> Kuninori Morimoto