Re: [PATCH 3/3] can: rcar_canfd: Handle Bus-Off recovery interrupt

[Marc Kleine-Budde]

On 03.04.2026 10:50:00, Biju wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Add handling for the Bus-Off recovery interrupt in the error handler.
> When the channel bus-off recovery interrupt is received, transition the
> CAN state back to CAN_STATE_ERROR_ACTIVE to reflect that the controller
> has successfully recovered from a bus-off event.

This looks wrong, better change the CAN state in
rcar_canfd_state_change(), so that can_change_state() is called and the
user gets informed.

BTW: The transition to bus-off should also be done via this function for
the same reason. This would be a proper fixes patch, that should go in
first.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature