Re: [PATCH v5 3/7] staging: rtl8723bs: rename EFUSE_Read1Byte() to rtw_efuse_read_1_byte()

[Ethan Tidmore]

On Thu Apr 2, 2026 at 12:42 AM CDT, Linus Probert wrote:
> Renames EFUSE_Read1Byte to rtw_efuse_read_1_byte in order to conform to
> kernel code styl.

I missed that you misspelt style in my last review. Sorry about that.
Also, its generally wanted that you include the change logs in the
actual patches themselves.

Thanks,

ET
>
> Discovered using checkpatch.pl tool.
>
> Signed-off-by: Linus Probert <linus.probert@xxxxxxxxx>
> ---
> v5: No change
>
>  drivers/staging/rtl8723bs/core/rtw_efuse.c        | 6 +++---
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ++-
>  drivers/staging/rtl8723bs/include/rtw_efuse.h     | 2 +-
>  3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index a7b120cc70a3..d6212b3b0b1d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -26,7 +26,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
>  }
>  
>  /*-----------------------------------------------------------------------------
> - * Function:	EFUSE_Read1Byte
> + * Function:	rtw_efuse_read_1_byte
>   *
>   * Overview:	Copy from WMAC fot EFUSE read 1 byte.
>   *
> @@ -42,7 +42,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
>   *
>   */
>  u8
> -EFUSE_Read1Byte(
> +rtw_efuse_read_1_byte(
>  struct adapter *Adapter,
>  u16		Address)
>  {
> @@ -79,7 +79,7 @@ u16		Address)
>  	} else
>  		return 0xFF;
>  
> -} /* EFUSE_Read1Byte */
> +} /* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
>  u8
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 355167883f08..941c2ebef9e2 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -1559,7 +1559,8 @@ void Hal_ReadRFGainOffset(
>  
>  	if (!AutoloadFail) {
>  		Adapter->eeprompriv.EEPROMRFGainOffset = PROMContent[EEPROM_RF_GAIN_OFFSET];
> -		Adapter->eeprompriv.EEPROMRFGainVal = EFUSE_Read1Byte(Adapter, EEPROM_RF_GAIN_VAL);
> +		Adapter->eeprompriv.EEPROMRFGainVal = rtw_efuse_read_1_byte(Adapter,
> +									    EEPROM_RF_GAIN_VAL);
>  	} else {
>  		Adapter->eeprompriv.EEPROMRFGainOffset = 0;
>  		Adapter->eeprompriv.EEPROMRFGainVal = 0xFF;
> diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> index b8cd9e694f56..7b78fd5e583b 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> @@ -71,7 +71,7 @@ struct efuse_hal {
>  u8 rtw_efuse_calculate_word_counts(u8 word_en);
>  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data);
>  
> -u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address);
> +u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address);
>  void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType);
>  void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value);
>  void Rtw_Hal_ReadMACAddrFromFile(struct adapter *padapter);