Re: [PATCH v2 2/3] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logging in pm8xxx_read_raw
From: Andy Shevchenko
Date: Sat Apr 04 2026 - 15:29:52 EST
On Sat, Apr 04, 2026 at 03:26:32AM +0000, Antony Kurniawan Soemardi wrote:
> On 4/4/2026 4:54 AM, Dmitry Baryshkov wrote:
> > Does it also prevent users from spamming the dmesg?
>
> It should be for no such channel case. The only remaining error logs
> from pm8xxx_read_raw are timeout errors, which I don’t think would
> result in immediate spamming. Or should we remove the dev_err (at
> pm8xxx_read_channel_rsv) on timeout errors too?
Does the user get -ETIMEDOUT? If so, yes, message may be removed.
--
With Best Regards,
Andy Shevchenko