Re: [PATCH v2 4/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC
From: Bryan O'Donoghue
Date: Sat Apr 04 2026 - 20:22:00 EST
On 04/04/2026 13:55, Aleksandrs Vinarskis wrote:
+ io-channel-names = "sys_therm0",
+ "sys_therm1",
+ "sys_therm2",
+ "sys_therm3",
+ "sys_therm4",
+ "sys_therm5",
+ "sys_therm6";
io-channels-names = "lpddr5x-therm", "charger-left-therm", "charger-right-therm", "ssd-therm", "keyboard-therm"
+ };
};
&i2c7 {
@@ -1025,6 +1050,64 @@ rtmr0_1p8_reg_en: rtmr0-1p8-reg-en-state {
};
};
+&pmk8550_vadc {
+ /* Around DRAM */
+ channel@14c {
+ reg = <PM8350_ADC7_GPIO3_100K_PU(1)>;
+ qcom,hw-settle-time = <200>;
+ qcom,ratiometric;
+ label = "sys_therm0";
You might as well use the same name for the label "lpddr5-therm"
+ };
On thena the list is:
- "OPT temp"
- "CPU VR"
- "GPU VR"
- "Charging-1"
- "Charging-2"
- "WLAN"
- "WLAN (EE)"
So I think both the source and the sink should describe and be allowed to describe what it is io-channel-names = "fixed list" is too restrictive.
Much more useful to userspace to see a string "lpddr5-therm" than "sys_therm0".
---
bod