Re: [PATCH] gpu: nova-core: falcon: align firmware DMA object size to required block alignment

[Alexandre Courbot]

On Sun Apr 5, 2026 at 7:24 AM JST, John Hubbard wrote:
> On 4/4/26 5:14 AM, Alexandre Courbot wrote:
>> Commit a88831502c8f ("gpu: nova-core: falcon: use dma::Coherent")
>> dropped the nova-local `DmaObject` device memory type for the
>> kernel-global `Coherent` one.
>
> Hi Alex,
>
> The diffs look good, so:
>
> Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
>
>
> A small typo in 3 places changes the meaning enough to throw
> things off:
>
> The subject line should s/align/pad/. Alignment normally means
> adjusting the starting address, whereas padding is what you are
> doing here.

Oooh indeed that's a bad one. Thanks for catching this - I'll send a v2
to make applying easier.