Re: [PATCH v1 11/13] dt-bindings: hwinfo: Add starfive,jhb100-socinfo

[Krzysztof Kozlowski]

On Thu, Apr 02, 2026 at 10:49:43PM -0700, Changhuang Liang wrote:
> Add starfive,jhb100-socinfo for StarFive JHB100 SoC.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
>  .../hwinfo/starfive,jhb100-socinfo.yaml       | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwinfo/starfive,jhb100-socinfo.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwinfo/starfive,jhb100-socinfo.yaml b/Documentation/devicetree/bindings/hwinfo/starfive,jhb100-socinfo.yaml
> new file mode 100644
> index 000000000000..cc6b7d5a4c91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwinfo/starfive,jhb100-socinfo.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwinfo/starfive,jhb100-socinfo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JHB100 SoC platform chipid module
> +
> +maintainers:
> +  - Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> +
> +description:
> +  StarFive JHB100 SoC platform chipid module is represented by JHB100_PRODUCT_ID
> +  register which contains information about revision. This register is located
> +  under the syscon.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: starfive,jhb100-socinfo

No, not a separate device.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    chipid@38 {
> +        compatible = "starfive,jhb100-socinfo";
> +        reg = <0x38 0x4>;

One register is not a device. NAK.

Best regards,
Krzysztof