Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

[David Heidelberg]

On 05/04/2026 10:55, Krzysztof Kozlowski wrote:
> On 05/04/2026 10:01, David Heidelberg wrote:
> > On 05/04/2026 09:55, Krzysztof Kozlowski wrote:
> > > On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
> > > > Add documentation for Tianma display and touchscreen variant.
> > > >
> > > > While at it, correct binding documentation expectation.
> > >
> > > What expectation? What exactly did you corrected that you claim this is
> > > a fix?
> >
> > I would say the missing Tianma variant, which been with us for some time. The
>
> Expectation of missing Tianma? We don't have such expectations...

Ok.

> > follow up commit fixes the missing compatible and order, thus it would make
> > sense to me have also the dt-bindings part backported and fixed.
>
> You probably should read original discussion why this ended up like that.

All I found is

 The compatibility property is
 moved to the tianma variant, but it is not updated to avoid any
 further conflict with other projects/users that might depend on it.

> > I agree I don't have strong case here. Should I drop the tag, keep it or replace
> > it with Cc: stable@xxxxxxxxxxxxxxx?
>
> If you cannot explain what you are fixing, then this is not a fix.

Sure, I'll drop the tag.

> Best regards,
> Krzysztof

--
David Heidelberg