Re: [PATCH v3] hwmon: (it87) Add support for IT8689E

[Frank Crawford]

Markus,

On Sun, 2026-03-22 at 10:33 +0000, Markus Hoffmann wrote:
> Add support for the ITE IT8689E Super I/O chip. The IT8689E supports
> newer autopwm, 12mV ADC, 16-bit fans, six fans, six PWM channels,
> PWM frequency 2, six temperature inputs, AVCC3, temperature offset,
> and fan on/off control.

Sorry about leaving this until now, I only just noticed the small
change within the patch set to add fan on/off control.

> Give it8689 its own GPIO configuration block in it87_find() rather
> than sharing the it8620/it8628 block. The shared block reads
> IT87_SIO_PINX2_REG and either marks IN3 as internal AVCC or skips
> IN9. Because it8689 declares FEAT_AVCC3, IN9 is already marked as
> always-internal before the GPIO block is reached; applying the PINX2
> check would either create duplicate AVCC labels on IN3 and IN9 or
> incorrectly skip IN9.
> 
> Also update Documentation/hwmon/it87.rst and drivers/hwmon/Kconfig to
> document the newly supported chip.
> 
> Signed-off-by: Markus Hoffmann <markus@xxxxxxxxxxx>
> ---
> Changes in v3:
> - Fix AVCC/PINX2 conflict: give it8689 its own GPIO block instead of
>   sharing the it8620/it8628 block. The shared block applies an
>   IT87_SIO_PINX2_REG check that is incompatible with FEAT_AVCC3:
>   it either creates duplicate AVCC labels on IN3 and IN9, or skips
>   IN9 while its label remains visible. it8622 (also FEAT_AVCC3) is
>   handled the same way for the same reason.
> - Add FEAT_TEMP_OFFSET: verified on hardware, temp[1-3]_offset sysfs
>   attributes respond correctly.
> - Add FEAT_FANCTL_ONOFF: verified on hardware, writing 0 to
>   pwm1_enable is accepted.

While you say it is accepted, does it actually have any effect?  I'm
told by someone else playing with this chipset that this feature does
not really do anything, although it also doesn't cause any operational
issues.

> - Add Documentation/hwmon/it87.rst entry for IT8689E, update the chip
>   list in the Description section, add IT8689E description paragraph,
>   and fix the in9 note to also list IT8622E (which also has
> FEAT_AVCC3).
> - Add IT8689E to drivers/hwmon/Kconfig help text.

Regards
Frank