Re: [PATCH] iio: adc: nxp-sar-adc: zero-initialize dma_slave_config

[David Lechner]

On 4/6/26 4:53 AM, Shuvam Pandey wrote:
> nxp_sar_adc_start_cyclic_dma() only fills the RX-side members of
> dma_slave_config before passing it to dmaengine_slave_config().
> 
> Zero-initialize the structure so unused members do not contain stack
> garbage. Some DMA engines consult optional dma_slave_config fields, so
> leaving them uninitialized can cause DMA setup failures.
> 
> Fixes: 4434072a893e ("iio: adc: Add the NXP SAR ADC support for the s32g2/3 platforms")
> Signed-off-by: Shuvam Pandey <shuvampandey1@xxxxxxxxx>
> ---
>  drivers/iio/adc/nxp-sar-adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
> index 9efa883c277d..7d7b5a580167 100644
> --- a/drivers/iio/adc/nxp-sar-adc.c
> +++ b/drivers/iio/adc/nxp-sar-adc.c
> @@ -659,7 +659,7 @@ static void nxp_sar_adc_dma_cb(void *data)
>  static int nxp_sar_adc_start_cyclic_dma(struct iio_dev *indio_dev)
>  {
>  	struct nxp_sar_adc *info = iio_priv(indio_dev);
> -	struct dma_slave_config config;
> +	struct dma_slave_config config = {};

IIO style is to have space between braces.

Wait and see if Jonathan asks for a new version first though
before sending one for trivial changes like that.

>  	struct dma_async_tx_descriptor *desc;
>  	int ret;
>  

Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>