RE: [PATCH v6 4/4] iio: adc: ad4691: add SPI offload support

From: Sabau, Radu bogdan

Date: Mon Apr 06 2026 - 10:33:00 EST




> -----Original Message-----
> From: David Lechner <dlechner@xxxxxxxxxxxx>
> Sent: Monday, April 6, 2026 4:57 PM

...

> >
> > I also have to mention that the oversampling commit would then implement
> > AD4691_MANUAL_CHANNEL macro which would miss the OVERSAMPLING
> > infomask, and offload_manual_channels will be declared using it.
> > More than this, that commit would also add other
> ad4691_manual_channels[]
> > and ad4693_manual_channels[] arrays that would use that MACRO as well.
> >
> > Then, chip_info would have ad4691/93_channels assigned to it by default,
> > and indio_dev->channels will later be assigned at probe, depending on the
> > mode and offload.
> >
> > If different chip_info structs would be wanted still, then my best guess is
> > to have different info structures (perhaps new types) in chip_info by default.
> > Something like *sw_info and *offload_info.
>
> Yes, this is how I would do it too.
>

Ok then, will have different chip infos and each one will have respective channels
to them. Thanks for this, too!