Re: [PATCH v4 1/7] platform/x86/intel/pmt: Export PMT enumeration functions as GPL

[David Box]

On Fri, Apr 03, 2026 at 05:00:05PM -0700, Reinette Chatre wrote:
> Hi Tony,
> 
> On 3/30/26 2:43 PM, Tony Luck wrote:
> > The symbol_get() function requires that objects be GPL licensed.
> 
> I do not know if this cryptic note is sufficient for the driver's maintainers.
> Looking at the dependencies among symbols it does look possible to add more
> context here that makes it clear that this is the right and obvious thing to do
> for this driver. Doing so makes inclusion of this change just a formality. If
> it is not the right and obvious thing to do then I similarly expect a better
> motivation than some planned usage since any planned usage may cause a debate
> about whether it should be supported.
> 
> Reinette

Tony,

Something along the lines of this would make it clearer:

"Prepare PMT enumeration interfaces for GPL-only users by converting
intel_pmt_get_regions_by_feature() and intel_pmt_put_feature_group() to
EXPORT_SYMBOL_GPL(). This enables future users of these interfaces to
access them via symbol_get(), which requires GPL-exported symbols."

With that clarification, this looks good to me.

Acked-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>