Re: [PATCH 1/3] dt-bindings: pwm: Add Raspberry Pi RP1 PWM controller

From: Andrea della Porta

Date: Tue Apr 07 2026 - 04:27:09 EST


Hi Krzysztof,

On 09:52 Sun 05 Apr , Krzysztof Kozlowski wrote:
> On Fri, Apr 03, 2026 at 04:31:54PM +0200, Andrea della Porta wrote:
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
>
> Missing ref to pwm.yaml.

The reference to pwm.yaml is at line 13, as follows:

allOf:
- $ref: pwm.yaml#

currently right after the maintainers: block. Are you
suggesting to move it after the required: block?

>
> > +additionalProperties: false
>
> and this should be unevaluatedProperties. See other files.

Ack.

Many thanks,
Andrea

>
> Best regards,
> Krzysztof
>