Re: [PATCH 2/3] pinctrl: qcom: add the TLMM driver for the Nord platforms

[Linus Walleij]

Hi Bartosz,

thanks for your patch!

On Fri, Apr 3, 2026 at 3:28 PM Bartosz Golaszewski
<bartosz.golaszewski@xxxxxxxxxxxxxxxx> wrote:

> Add support for the TLMM controller on the Qualcomm Nord platform.
>
> Co-developed-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
(...)
> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11)    \
> +       {                                                             \
> +               .grp = PINCTRL_PINGROUP("gpio" #id,                   \
> +                                       gpio##id##_pins,              \
> +                                       ARRAY_SIZE(gpio##id##_pins)), \
> +               .ctl_reg = REG_SIZE * id,                             \
> +               .io_reg = 0x4 + REG_SIZE * id,                        \
> +               .intr_cfg_reg = 0x8 + REG_SIZE * id,                  \
> +               .intr_status_reg = 0xc + REG_SIZE * id,               \
> +               .intr_target_reg = 0x8 + REG_SIZE * id,               \

You can drop .intr_target_reg as of:

commit 0720208b37ae4f1193dc7103ee269b180a8f8943
Author: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
Date:   Fri Mar 27 22:42:40 2026 +0530

    pinctrl: qcom: Drop redundant intr_target_reg on modern SoCs

    On all Qualcomm TLMM generations from APQ8084 onwards, the interrupt
    target routing bits are located in the same register as the interrupt
    configuration bits (intr_cfg_reg). Only five older SoCs — APQ8064,
    IPQ8064, MDM9615, MSM8660 and MSM8960 — have a genuinely separate
    interrupt target routing register at a different offset (0x400 + 0x4 * id).

    Replace MSM_ACCESSOR(intr_target) with a custom accessor that falls back
    to intr_cfg_reg when intr_target_reg is zero. Apply the same fallback in
    the SCM path. Drop the now-redundant .intr_target_reg initializer from
    all SoC drivers where it duplicated intr_cfg_reg, keeping it only in
    the five drivers where it genuinely differs.

    Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
    Signed-off-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij