Re: [PATCH] printf: mark errptr() noinline

[David Laight]

On Wed, 8 Apr 2026 14:29:59 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> On Wed, Apr 08, 2026 at 10:04:25AM +0100, David Laight wrote:
> > On Wed, 8 Apr 2026 09:24:58 +0200
> > Petr Mladek <pmladek@xxxxxxxx> wrote:  
> > > On Tue 2026-04-07 16:08:09, David Laight wrote:  
> > > > On Mon, 6 Apr 2026 12:32:32 -0400
> > > > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:  
> > > > > On Mon, 6 Apr 2026 11:21:39 -0400
> > > > > Tamir Duberstein <tamird@xxxxxxxxxx> wrote:  
> 
> ...
> 
> > > > Even having the KASAN/KMSAN code compiled into allmodconfig is a PITA
> > > > when you are trying to check that code compiles to something sensible.    
> > > 
> > > This does not look like a good idea. KASAN/KMSAN are very useful
> > > features. People will want to keep them working. Removing them from
> > > randconfig would just postpone detection of the problem. We would
> > > need to deal with it sooner or later anyway.  
> > 
> > True, but when I build an allmodconfig build to check how the asm looks
> > I really don't want them.  
> 
> Isn't easy to disable that in the command line to `make`?

It is a config option, and I think you need to reset it every time you
rerun 'make allmodconfig' to pick up config changes.

You can enable -Werror with W=e, but not disable it if you want
to set W=1.
I did have a patch that let you use W=1-e which is useful.

	David

> 
> > For the 'bot' builds you also want to know whether they are defined.
> > Changes to how things are built rather than what is built can throw
> > up unexpected warnings that are very hard to pin down.
> > 
> > It is bad enough finding things that affect one obscure architecture
> > with a specific compiler version when the compiler just makes slightly
> > different decisions, without having unusual compilation/config options
> > is the mix to muddy the waters further.  
>