Re: [PATCH net-next v11 05/10] bng_en: add support for link async events

[Vadim Fedorenko]

On 03/04/2026 08:37, Bhargava Marreddy wrote:
> Register for firmware asynchronous events, including link-status,
> link-speed, and PHY configuration changes. Upon event reception,
> re-query the PHY and update ethtool settings accordingly.
>
> Signed-off-by: Bhargava Marreddy <bhargava.marreddy@xxxxxxxxxxxx>
> Reviewed-by: Vikas Gupta <vikas.gupta@xxxxxxxxxxxx>
> Reviewed-by: Rajashekar Hudumula <rajashekar.hudumula@xxxxxxxxxxxx>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@xxxxxxxxxxxx>
> ---
>   .../ethernet/broadcom/bnge/bnge_hwrm_lib.c    | 19 +++++++++-
>   .../net/ethernet/broadcom/bnge/bnge_link.c    | 18 ++++++++++
>   .../net/ethernet/broadcom/bnge/bnge_link.h    |  1 +
>   .../net/ethernet/broadcom/bnge/bnge_netdev.c  | 23 ++++++++++++
>   .../net/ethernet/broadcom/bnge/bnge_txrx.c    | 35 ++++++++++++++++---
>   5 files changed, 91 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
> index acb712ddbd7e..de51add96ac3 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
> @@ -15,6 +15,13 @@
>   #include "bnge_rmem.h"
>   #include "bnge_resc.h"
>   
> +static const u16 bnge_async_events_arr[] = {
> +	ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE,
> +	ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE,
> +	ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE,
> +	ASYNC_EVENT_CMPL_EVENT_ID_PORT_PHY_CFG_CHANGE,
> +};
> +
>   int bnge_hwrm_ver_get(struct bnge_dev *bd)
>   {
>   	u32 dev_caps_cfg, hwrm_ver, hwrm_spec_code;
> @@ -166,10 +173,12 @@ int bnge_hwrm_fw_set_time(struct bnge_dev *bd)
>   
>   int bnge_hwrm_func_drv_rgtr(struct bnge_dev *bd)
>   {
> +	DECLARE_BITMAP(async_events_bmap, 256);
>   	struct hwrm_func_drv_rgtr_output *resp;
>   	struct hwrm_func_drv_rgtr_input *req;
> +	u32 events[8];
>   	u32 flags;
> -	int rc;
> +	int rc, i;
>   
>   	rc = bnge_hwrm_req_init(bd, req, HWRM_FUNC_DRV_RGTR);
>   	if (rc)
> @@ -190,6 +199,14 @@ int bnge_hwrm_func_drv_rgtr(struct bnge_dev *bd)
>   	req->ver_min = cpu_to_le16(DRV_VER_MIN);
>   	req->ver_upd = cpu_to_le16(DRV_VER_UPD);
>   
> +	memset(async_events_bmap, 0, sizeof(async_events_bmap));

bitmap API has bitmap_zero()

> +	for (i = 0; i < ARRAY_SIZE(bnge_async_events_arr); i++)
> +		__set_bit(bnge_async_events_arr[i], async_events_bmap);
> +
> +	bitmap_to_arr32(events, async_events_bmap, 256);
> +	for (i = 0; i < ARRAY_SIZE(req->async_event_fwd); i++)
> +		req->async_event_fwd[i] |= cpu_to_le32(events[i]);
> +
>   	resp = bnge_hwrm_req_hold(bd, req);
>   	rc = bnge_hwrm_req_send(bd, req);
>   	if (!rc) {