Re: [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B

[Takashi Iwai]

On Thu, 09 Apr 2026 08:33:19 +0200,
Zhang Heng wrote:
> 
> Some machines also need to write GPIO again after waking up from sleep,
> 
> please consider this.

Sure, but your patch puts one extra unnecessary GPIO operation than
needed, and it can be optimized later -- that's my point.  The fixup
could deal directly with only GPIO high/low only once.  With the
current alc_*_gpio() helpers, the values are cached and it's restored
already once before the fixup at each resume call.  So we'd need some
tune up in the helper code for this optimization.


Takashi

> 
> 在 2026/4/9 14:30, Takashi Iwai 写道:
> > That said, I'm going to take your patch for now, but we might need to
> > reconsider the implementation of Realtek codec helpers about GPIO
> > handling.
> >