Re: [PATCH] platform/x86: asus-wmi: fix camera key led on Zenbook S14

[Ilpo Järvinen]

On Thu, 2 Apr 2026, José Guilherme de Castro Rodrigues wrote:

> On Tue, Mar 31, 2026 at 08:01:47PM -0300, José Guilherme de Castro Rodrigues wrote:
> > 
> > This change is not visible to userspace, as no sysfs attribute for
> > ASUS_WMI_DEVID_CAMERA_LED_NEG exists.
> >  
> > +	if (is_camera_toggle(code) && asus->camera_neg_led_available) {
> > +		camera_neg_led_trigger_update(asus);
> > +		return;
> > +	}
> > +
> >  	if (!sparse_keymap_report_event(asus->inputdev, code,
> >  					key_value, autorelease))
> >  		pr_info("Unknown key code 0x%x\n", code);
> 
> This change is actually visible to userspace because I'm early returning
> and that means the event for the camera key is not propagated to
> userspace. Sashiko correctly identified that, as well as another detail
> in formatting (using space instead of tab for indentation on the newly
> added macros). The event is currently not used on my system, so I didn't
> notice it before.
> 
> Removing the return fixes this. I can send a new version of the patch if
> necessary.

Please just send a new version. It will be much easier for me when I don't 
need to hunt down odd spaces or do multi-line code edits.

-- 
 i.