Re: [PATCH net-next v2 1/5] tools: ynl: move ethtool.py to selftest

[Stanislav Fomichev]

On 04/08, Jakub Kicinski wrote:
> On Wed, 8 Apr 2026 09:42:33 -0700 Stanislav Fomichev wrote:
> > > @@ -8,7 +8,7 @@ KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests
> > >  source "$KSELFTEST_KTAP_HELPERS"
> > >  
> > >  # Default ynl-ethtool path for direct execution, can be overridden by make install
> > > -ynl_ethtool="../pyynl/ethtool.py"
> > > +ynl_ethtool="./ethtool.py"
> > >  
> > >  readonly NSIM_ID="1337"
> > >  readonly NSIM_DEV_NAME="nsim${NSIM_ID}"  
> > 
> > Do we need to add some expects/asserts to the script to really make it into
> > a test? Right now it just prints things, so it's not really a test.
> 
> This file is full of asserts? It's a bash script that runs ethtool.py 
> and checks the output. Which one of us is missing the point ? :)

Oh, yes, I did miss the script!