Re: [PATCH v4 0/2] hwmon: pmbus: Sony APS-379

[Guenter Roeck]

On Thu, Apr 09, 2026 at 09:02:43PM +0000, Chris Packham wrote:
> 
> On 02/04/2026 23:38, Guenter Roeck wrote:
> > On 4/1/26 19:40, Chris Packham wrote:
> >> This series add support for the PMBus hwmon on the Sony
> >> APS-379 power supply module. There's some deviations from
> >> the PMBus specification that need to be dealt with.
> >>
> >> Chris Packham (2):
> >>    dt-bindings: trivial-devices: Add sony,aps-379
> >>    hwmon: pmbus: Add support for Sony APS-379
> >>
> >>   .../devicetree/bindings/trivial-devices.yaml  |   2 +
> >>   Documentation/hwmon/aps-379.rst               |  58 ++++++
> >>   Documentation/hwmon/index.rst                 |   1 +
> >>   drivers/hwmon/pmbus/Kconfig                   |   6 +
> >>   drivers/hwmon/pmbus/Makefile                  |   1 +
> >>   drivers/hwmon/pmbus/aps-379.c                 | 178 ++++++++++++++++++
> >>   6 files changed, 246 insertions(+)
> >>   create mode 100644 Documentation/hwmon/aps-379.rst
> >>   create mode 100644 drivers/hwmon/pmbus/aps-379.c
> >>
> >
> > Sashiko still doesn't like it.
> >
> > https://sashiko.dev/#/patchset/20260402024101.4136697-1-chris.packham%40alliedtelesis.co.nz 
> >
> 
> Just out if interest is this something I should be looking to run before 
> submitting? I was put off by the low quality results (and dubious 
> license) of some of the earlier AI code assistants so I tend to avoid 
> them. Time to revisit perhaps.
> 

The latest AI models (both Claude and Gemini) are surprisingly good with
code reviews. Failures are often because of missing context information
(for example, Sashiko doesn't know that I3C selects I2C, and thus that
CONFIG_I3C=m and CONFIG_I2C=n is not possible). However, it finds lots of
problems that I (as human reviewer) had overlooked. Which means that, at
this point, I trust it more than I trust my own reviews.

For this reason, Sashiko now sends review feedback for all patches
submitted into the hardware monitoring subsystem.

So, yes, everyone should look into the results. If there are obviously
wrong results provided by the AI, we should [try to] fix them in the AI
prompts. Sashiko is public, so everyone can chime in and submit prompt
updates.

Thanks,
Guenter