Re: [PATCH v7 1/3] ASoC: tac5xx2-sdw: add soundwire based codec driver

[Mark Brown]

On Fri, Apr 10, 2026 at 02:55:34PM +0530, Niranjan H Y wrote:
> Add codec driver for tac5xx2 family of devices.

> +
> +static int tac5xx2_set_jack(struct snd_soc_component *component,
> +			    struct snd_soc_jack *hs_jack, void *data)
> +{

> +	tac_dev->hs_jack = hs_jack;
> +	if (!tac_dev->hw_init) {
> +		dev_err(tac_dev->dev, "jack init failed, hw not initialized");
> +		return 0;
> +	}
> +
> +	ret = regmap_write(tac_dev->regmap, SDW_SCP_SDCA_INTMASK2,
> +			   SDW_SCP_SDCA_INTMASK_SDCA_11);
> +	if (ret) {
> +		dev_warn(tac_dev->dev,
> +			 "Failed to register jack detection interrupt");
> +		goto disable_interrupts;
> +	}

Fairly minor since I'm not sure anything will actually do this but if
jack is set to NULL to disable the jack this will still leave the
interrupts enabled - the driver should turn them off.  Probably also a
good idea to lock in case there's jack detection going on during a
disable.

Attachment: signature.asc
Description: PGP signature