Re: [PATCH v7 0/8] hwmon: (ina3221) Various improvement and add support for SQ52210

[Guenter Roeck]

Hi,

On 4/2/26 01:13, Wenliang Yan wrote:
> Changes in v7:
> - Fixed unnecessary semicolon in ina3221_read_value()
>    (reported by kernel test robot)
>
> I will address any additional feedback in the next version.
> Thank you for your time
Sashiko reports lots of issues with this series. Some of it is irrelevant
(for example, enum values for chip types are always lower case in the hwmon subsystem),
but many are real problems. Please take a look.

Thanks,
Guenter

> ---
> v6: https://lore.kernel.org/linux-hwmon/20260225090324.112145-1-wenliang202407@xxxxxxx/
> v5: https://lore.kernel.org/linux-hwmon/20260119121446.17469-1-wenliang202407@xxxxxxx/
> v4: https://lore.kernel.org/linux-hwmon/20260114081741.111340-1-wenliang202407@xxxxxxx/
> v3: https://lore.kernel.org/linux-hwmon/20251120081921.39412-1-wenliang202407@xxxxxxx/
> v2: https://lore.kernel.org/linux-hwmon/20251118125148.95603-1-wenliang202407@xxxxxxx/
> v1: https://lore.kernel.org/linux-hwmon/20251111080546.32421-1-wenliang202407@xxxxxxx/
>
> Wenliang Yan (8):
>    dt-bindings: hwmon: ti,ina3221: Add SQ52210
>    hwmon: (ina3221) Add support for SQ52210
>    hwmon: (ina3221) Pre-calculate current and power LSB
>    hwmon: (ina3221) Support alert configuration
>    hwmon: (ina3221) Introduce power attribute and alert characteristics
>    hwmon: (ina3221) Modify the 'ina3221_read_value' function
>    hwmon: (ina3221) Support alert_limit_write function and write/read
>      functions for 'power' attribute
>    hwmon: (ina3221) Modify write/read functions for 'in' and 'curr'
>      attribute
>
>   .../devicetree/bindings/hwmon/ti,ina3221.yaml |  15 +-
>   Documentation/hwmon/ina3221.rst               |  24 +
>   drivers/hwmon/ina3221.c                       | 548 +++++++++++++++++-
>   3 files changed, 571 insertions(+), 16 deletions(-)