Re: [PATCH 1/2] staging: rtl8723bs: fix coding style issues in sdio_halinit.c

[Luka Gejak]

On Sat, 11 Apr 2026 22:40:00 +0100, Josh Hesketh wrote:

-/* 	u8 bMacPwrCtrlOn; */
+/*	u8 bMacPwrCtrlOn; */

Instead of fixing the spacing in commented-out code, please just 
remove dead code entirely. Git tracks previous versions for us. 

-/* 	==== Reset digital sequence   ====== */
+/*	==== Reset digital sequence   ====== */

Fixing standard comments like this one is fine, but the commented-out 
code blocks above should be removed.

-	u8 	bResult = _SUCCESS;
+	u8 bResult = _SUCCESS;

This change is good and follows kernel coding style.

You should split patch 1 into 3 patches: one for deleting the 
commented-out code, another for the legitimate whitespace fixes 
and one for adding newlines. Also one more thing this patch series 
doesn't apply on top of staging-next so please rebase on staging-next 
branch in v2 and don't forget to write changes in v2 part under --- in
patch 1 and patch 2.
Best regards,
Luka Gejak