Re: [PATCH v2 2/3] staging: rtl8723bs: fix whitespace issues in sdio_halinit.c

[Luka Gejak]

On April 12, 2026 5:06:32 PM GMT+02:00, Josh Hesketh <josh.hesketh@xxxxxxxxx> wrote:
>Remove spaces before tabs in comments and fix extra spaces to
>address checkpatch warnings.
>
>Signed-off-by: Josh Hesketh <josh.hesketh@xxxxxxxxx>
>---
>v2:
> - Rebased on staging-next
> - Split from original patch 1/2
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 ++++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index 4d74b14c3cd4..4a4f6b03253a 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -822,7 +822,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
> 
> /*  */
> /*  Description: */
>-/* 	RTL8723e card disable power sequence v003 which suggested by Scott. */
>+/*	RTL8723e card disable power sequence v003 which suggested by Scott. */
> /*  */
> /*  First created by tynli. 2011.01.28. */
> /*  */
>@@ -834,7 +834,7 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
> 	/*  Run LPS WL RFOFF flow */
> 	HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
> 
>-	/* 	==== Reset digital sequence   ====== */
>+	/*	==== Reset digital sequence   ====== */
> 
> 	val = rtw_read8(padapter, REG_MCUFWDL);
> 	if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
>@@ -857,7 +857,7 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
> 	val |= BIT(0);
> 	rtw_write8(padapter, REG_RSV_CTRL + 1, val);
> 
>-	/* 	==== Reset digital sequence end ====== */
>+	/*	==== Reset digital sequence end ====== */
> 
> 	bMacPwrCtrlOn = false;	/*  Disable CMD53 R/W */
> 	rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
>@@ -959,13 +959,13 @@ void rtl8723bs_interface_configure(struct adapter *padapter)
> }
> 
> /*  */
>-/* 	Description: */
>-/* 		We should set Efuse cell selection to WiFi cell in default. */
>+/*	Description: */
>+/*		We should set Efuse cell selection to WiFi cell in default. */
> /*  */
>-/* 	Assumption: */
>-/* 		PASSIVE_LEVEL */
>+/*	Assumption: */
>+/*		PASSIVE_LEVEL */
> /*  */
>-/* 	Added by Roger, 2010.11.23. */
>+/*	Added by Roger, 2010.11.23. */
> /*  */
> static void _EfuseCellSel(struct adapter *padapter)
> {
>@@ -1051,7 +1051,7 @@ static void _ReadEfuseInfo8723BS(struct adapter *padapter)
> static void _ReadPROMContent(struct adapter *padapter)
> {
> 	struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
>-	u8 	eeValue;
>+	u8 eeValue;
> 
> 	eeValue = rtw_read8(padapter, REG_9346CR);
> 	/*  To check system boot selection. */
>@@ -1062,11 +1062,11 @@ static void _ReadPROMContent(struct adapter *padapter)
> }
> 
> /*  */
>-/* 	Description: */
>-/* 		Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
>+/*	Description: */
>+/*		Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
> /*  */
>-/* 	Assumption: */
>-/* 		PASSIVE_LEVEL (SDIO interface) */
>+/*	Assumption: */
>+/*		PASSIVE_LEVEL (SDIO interface) */
> /*  */
> /*  */
> static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)
>@@ -1179,14 +1179,14 @@ void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int l
> }
> 
> /*  */
>-/* 	Description: */
>-/* 		Query setting of specified variable. */
>+/*	Description: */
>+/*		Query setting of specified variable. */
> /*  */
> u8 GetHalDefVar8723BSDIO(
> 	struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue
> )
> {
>-	u8 	bResult = _SUCCESS;
>+	u8 bResult = _SUCCESS;
> 
> 	switch (eVariable) {
> 	case HAL_DEF_IS_SUPPORT_ANT_DIV:

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>