RE: [PATCH] EDAC/i10nm: don't fail probing if ADXL is missing
From: Zhuo, Qiuxu
Date: Tue Apr 14 2026 - 10:32:58 EST
> From: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> Sent: Tuesday, April 14, 2026 7:14 AM
> To: Luck, Tony <tony.luck@xxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; linux-
> edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Vasiliy Khoruzhick <vasilykh@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
> Subject: [PATCH] EDAC/i10nm: don't fail probing if ADXL is missing
s/don't/Don't/
> From: Vasily Khoruzhick <vasilykh@xxxxxxxxxx>
>
> ADXL is not present in Coreboot- or Slimbootloader-based BIOSes and as
> result, the driver fails to probe there.
>
> i10nm does not require ADXL for decoding errors since commit
ADXL provides more detailed decoded results than the driver decoder.
It's the preferred method when decoding performance is not a concern.
> 2738c69a8813 ("EDAC/i10nm: Add driver decoder for Ice Lake and Tremont
> CPUs"), so we can just switch to driver decoding when it's not present.
>
You could phrase this commit message like:
Since commit 2738c69a8813 ("EDAC/i10nm: Add driver decoder for Ice Lake and Tremont CPUs"),
i10nm_edac supports driver decoder. Switch to driver decoding when ADXL is not present.
Btw, please drop the personal pronoun 'we' and use the imperative tone.
> Cc: stable@xxxxxxxxxxxxxxx # v6.1+
> Signed-off-by: Vasily Khoruzhick <vasilykh@xxxxxxxxxx>
Other than the comments above:
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
[...]