Re: [PATCH v7 13/22] x86/virt/seamldr: Install a new TDX module
From: Edgecombe, Rick P
Date: Tue Apr 14 2026 - 13:36:40 EST
On Tue, 2026-04-14 at 18:19 +0800, Chao Gao wrote:
> > Why the style difference? It would be good to standardize, but the existing
> > code
> > isn't standardized. What do you think about going with this style through
> > the
> > series for the one arg ones?
>
> Sure, happy to standardize. To confirm, you prefer this style?
>
> struct tdx_module_args args = { .rcx = __pa(params) };
>
> it looks more common than the other way.
They both seem fine to me. And, yes, this is probably in the nit category. But
if it looks sloppy it can add doubts to the code for the final review.