Re: [PATCH v4 7/7] dt-bindings: PCI: intel,lgm-pcie: Add atu resource

[Rob Herring]

On Wed, Apr 15, 2026 at 7:26 AM Florian Eckert <fe@xxxxxxxxxx> wrote:
>
>
>
> On 2026-04-15 14:09, Rob Herring wrote:
> > On Wed, Apr 15, 2026 at 3:02 AM Florian Eckert <fe@xxxxxxxxxx> wrote:
> >>
> >> The 'atu' information is already set in the dwc core, if it is
> >> specified
> >> in the devicetree. The driver uses its own default, if not set in the
> >> devicetree. This information is hardware specific and should therefore
> >> be
> >> maintained in the devicetree rather than in the source.
> >>
> >> To be backward compatible, this field is not mandatory. If 'atu'
> >> resource is not specified in the devicetree, the driver’s default
> >> value
> >> is used.
> >>
> >> Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++--
> >>  1 file changed, 6 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> >> b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> >> index
> >> 54e2890ae6314ac6847fc23f49440d05d66d87d4..9b7a8ef77585677841c7064c5001110bc2b65db1
> >> 100644
> >> --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> >> +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> >> @@ -27,16 +27,19 @@ properties:
> >>        - const: snps,dw-pcie
> >>
> >>    reg:
> >> +    minItems: 3
> >>      items:
> >>        - description: Controller control and status registers.
> >>        - description: PCIe configuration registers.
> >>        - description: Controller application registers.
> >> +      - description: Internal Address Translation Unit (iATU)
> >> registers.
> >>
> >>    reg-names:
> >
> > Don't you need minItems here?
>
> You're absolutely right, of course!
> My fault. Thanks for pointing that out.
> I will wait 24 hours to send a v5 with this change.
>
> Just to clarify. How does the creator of DTS know which items are
> required.
> Does that mean, in this case, that the last item is always optional and
> the
> others are absolutely essential?

Correct. There is no way in json-schema to express some entry in the
middle of an 'items' list is optional.

Rob