Re: [PATCH 1/2] KVM: x86: Ensure vendor's exit handler runs before fastpath userspace exits

From: Nikunj A. Dadhania

Date: Fri Apr 24 2026 - 00:29:35 EST




On 4/23/2026 9:56 PM, Sean Christopherson wrote:
> Move the handling of fastpath userspace exits into vendor code to ensure
> KVM runs vendor specific operations that need to run before userspace gains
> control of the vCPU. E.g. for VMX (and soon to be for SVM as well), KVM
> needs to flush the PML buffer prior to exiting to userspace, otherwise any
> memory written by the final KVM_RUN might never be flagged as dirty.
>
> Note, waiting to snapshot CR0 and CR3 until svm_handle_exit() is flawed in
> general, as that risks consuming stale state in a fastpath handler. That
> will be addressed in a future change.
>
> Fixes: f7f39c50edb9 ("KVM: x86: Exit to userspace if fastpath triggers one on instruction skip")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Nikunj A. Dadhania <nikunj@xxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Reviewed-by: Nikunj A. Dadhania <nikunj@xxxxxxx>