Re: [PATCH 2/2] ARM: dts: qcom: Support Motorola Moto G2 (2014)

[Konrad Dybcio]

On 4/23/26 3:24 PM, David Wales via B4 Relay wrote:
> From: David Wales <daviewales@xxxxxxxxxxx>
> 
> Add device tree for Motorola Moto G2 (2014) (motorola-titan) smartphone
> based on the Qualcomm MSM8226 SoC.
> 
> Initially supported features:
>   - Buttons (Volume Down/Up, Power)
>   - eMMC
>   - Hall Effect Sensor
>   - Simple framebuffer display
>   - Vibrator
> 
> Based on device tree for similar device msm8226-motorola-falcon.
> Initial commit for falcon notes that dhob and shob reserved-memory
> regions seem to be related to a Motorola specific mechanism. [1]
> 
> [1] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/Documentation/devicetree/bindings/misc/hob_ram.txt
> 
> Signed-off-by: David Wales <daviewales@xxxxxxxxxxx>
> ---

[...]

> +&tlmm {
> +	reg_lcd_default: reg-lcd-default-state {
> +		pins = "gpio12", "gpio13";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-disable;
> +		output-high;

This line will keep these regulators always-enabled, until (which
may perhaps never happen) the driver takes over, it should be
unnecessary

otherwise lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad