Re: [PATCH net-next v2] netlink: clean up failed initial dump-start state
From: Michael Bommarito
Date: Fri Apr 24 2026 - 07:49:09 EST
On Thu, Apr 23, 2026 at 9:50 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> Looks like this changes existing behavior :(
> The tools/testing/selftests/net/netlink-dumps.c test used to always
> see a NLMSG_DONE now it doesn't. Maybe this change is more risk
> than reward?
>
> process nit: please don't post new versions in reply to previous
Sorry about both of those. And yes, I think you're right about
risk-reward. While it's fully unprivileged and could cause issues on
very small devices, it's probably only worth addressing if someone is
touching errout_skb and related branches for some other bigger reason.
Maybe the shared cleanup pattern is helpful in the future but I'll
drop this unless you say otherwise
Thanks,
Mike Bommarito