Re: [PATCH 7.2 v10 0/2] skip redundant sync IPIs when TLB flush sent them
From: David Hildenbrand (Arm)
Date: Fri Apr 24 2026 - 15:09:40 EST
On 4/24/26 20:50, Yosry Ahmed wrote:
> On Fri, Apr 24, 2026 at 11:36 AM David Hildenbrand (Arm)
> <david@xxxxxxxxxx> wrote:
>>
>> On 4/24/26 16:31, Andrew Morton wrote:
>>>
>>>
>>> Why do you think so?
>>
>> The most important part for me is that authors are aware of the reports.
>>
>> Sending them as a mail forces people to publicly reply to the feedback, and at
>> this point in time, I am not convinced that that is the right approach.
>
> But I imagine it's useful for reviewers to see Sashiko's feedback as
> well (without having to go look on the website).
I read a lot of them, yes. Maintainers know how to find it.
I even think maintainers should briefly go over it before applying to spot if
anything in there is still left unanswered. But that doesn't need a mailing list
posting.
I enjoy if contributors are aware of the reports and use that input in a
reasonable, like Zi just did [1]. And if they are unsure, they usually ask to
double-check.
[1] https://lore.kernel.org/r/15191F7F-0D10-4907-B963-DA4EA0E36EB6@xxxxxxxxxx
> It's possible that
> Sashiko is right but the author isn't convinced, so getting more eyes
> on the feedback would help.
Forcing contributors to reply to everything. I don't like that, in particular
not as long as there is no way for contributors to run it early in private.
In most cases, contributors just do the reasonable thing: incorporate the
feedback in a new version.
--
Cheers,
David