RE: [Intel-wired-lan] [PATCH iwl-net v7 2/3] ice: fix missing dpll notifications for SW pins

[Nowlin, Alexander]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Petr Oros
> Sent: Friday, April 17, 2026 7:59 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Vecera, Ivan <ivecera@xxxxxxxxxx>; Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxx>; Rinitha, SX <sx.rinitha@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; 
> Eric Dumazet <edumazet@xxxxxxxxxx>; Kubalewski, Arkadiusz <arkadiusz.kubalewski@xxxxxxxxx>; Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Nguyen, 
> Anthony L <anthony.l.nguyen@xxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni 
> <pabeni@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH iwl-net v7 2/3] ice: fix missing dpll notifications for SW pins
> 
> The SMA/U.FL pin redesign (commit 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control")) introduced software-controlled pins that wrap backing CGU input/output pins, but never updated the notification > and data paths to propagate pin events to these SW wrappers.
> 
> The periodic work sends dpll_pin_change_ntf() only for direct CGU input pins.  SW pins that wrap these inputs never receive change or phase offset notifications, so userspace consumers such as synce4l 
> monitoring SMA pins via dpll netlink never learn about state transitions or phase offset updates.  Similarly, ice_dpll_phase_offset_get() reads the SW pin's own phase_offset field which is never updated; the PPS 
> monitor writes to the backing CGU input's field instead.
> 
> Fix by introducing ice_dpll_pin_ntf(), a wrapper around
> dpll_pin_change_ntf() that also notifies any registered SMA/U.FL pin whose backing CGU input matches.  Replace all direct
> dpll_pin_change_ntf() calls in the periodic notification paths with this wrapper.  Fix ice_dpll_phase_offset_get() to return the backing CGU input's phase_offset for input-direction SW pins.
> 
> Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control")
> Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ice/ice_dpll.c | 47 +++++++++++++++++------
>  1 file changed, 36 insertions(+), 11 deletions(-)

Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>