Re: [PATCH] iio: adc: meson-saradc: fix calibration buffer leak on error

From: Felix Gu

Date: Sat Apr 25 2026 - 23:55:08 EST


On Sun, Apr 26, 2026 at 7:16 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> I just updated iio/testing today and I see return without kfree().
>
> priv->tsc_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "amlogic,hhi-sysctrl");
> if (IS_ERR(priv->tsc_regmap))
> return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap),
> "failed to get amlogic,hhi-sysctrl regmap\n");
> >> Should `#include <linux/cleanup.h>` though rather that relying on it being
> >> included through another header.
> >>
> >> With that fixed...
> >>
> >> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> >>
> >
>
Hi Jonathan,
This code was merged into linux/master yesterday, perhaps you haven't
updated the code base.

Best regards,
Felix