Re: [PATCH net-next] net: bcmasp: handle EPROBE_DEFER for MAC retrieval

[Andrew Lunn]

On Fri, Apr 24, 2026 at 06:37:34PM -0700, Rosen Penev wrote:
> of_get_ethdev_address can return EPROBE_DEFER when using nvmem. To
> handle this, encode the error with ERR_PTR for minimal changes. Adjust
> the only place using bcmasp_interface_create.
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp.c      | 4 ++--
>  drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 6 ++++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index 972474893a6b..31a9560c4aee 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1333,10 +1333,10 @@ static int bcmasp_probe(struct platform_device *pdev)
>  	i = 0;
>  	for_each_available_child_of_node_scoped(ports_node, intf_node) {
>  		intf = bcmasp_interface_create(priv, intf_node, i);
> -		if (!intf) {
> +		if (IS_ERR(intf)) {
>  			dev_err(dev, "Cannot create eth interface %d\n", i);

Idealy, this should be changed to dev_err_probe(), so the
EPROBE_DEFFER case does not spam the log.

    Andrew

---
pw-bot: cr