Re: [PATCH v2] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page

[David Hildenbrand (Arm)]

On 4/27/26 08:37, Sunny Patel wrote:
> When migrate_vma_insert_huge_pmd_page() jumps to unlock_abort due
> to a PMD check failure, the pgtable allocated earlier via
> pte_alloc_one() is never freed, causing a memory leak.
> 
> Add a pte_free() call in the unlock_abort error path to release
> the pgtable before returning.Also included before goto abort in the
> folio check path.
> 
> Signed-off-by: Sunny Patel <nueralspacetech@xxxxxxxxx>
> ---

Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device
pages")
Cc: <stable@xxxxxxxxxxxxxxx>

Sashiko moans about a lot of unrelated stuff, one of them fixed by your other
fix, and one of them to be cleaned up by your other patch.

There is another thing about migrate_vma_split_folio() and temporary
split_folio() failures which I think we can ignore.

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

-- 
Cheers,

David