Re: [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe

From: Andy Shevchenko

Date: Mon Apr 27 2026 - 04:20:28 EST


On Sun, Apr 26, 2026 at 02:47:09PM +0530, Sanjay Chitroda wrote:

> dev_err_probe() makes error code handling simpler and handle
> deferred probe nicely (avoid spamming logs).

...

> - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> - sensorhub_sensor_devs,
> + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, sensorhub_sensor_devs,
> ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);

This change can be done when converting to devm, it doesn't belong here.

> +

This is stray blank line now...

> + if (ret < 0)
> + return dev_err_probe(dev, ret, "mfd add devices fail\n");

--
With Best Regards,
Andy Shevchenko