Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock

From: Mark Brown

Date: Mon Apr 27 2026 - 20:03:41 EST


On Mon, Apr 27, 2026 at 07:00:59PM +0200, Uwe Kleine-König wrote:
> On Mon, Apr 27, 2026 at 08:30:27AM +0900, Mark Brown wrote:

> > [1/1] ASoC: ES8389: convert to devm_clk_get_optional() to get clock
> > https://git.kernel.org/broonie/sound/c/8ed331113107

> I see you dropped the Fixes: line, but I still think the commit log is
> wrongly blaming abae8e57e49a. Unless I'm missing something, abae8e57e49a
> didn't change behaviour of devm_clk_get() or devm_clk_get_optional(), so
> "since commit abae8e57e49a ("clk: generalize devm_clk_get() a bit"),
> devm_clk_get() would return an error pointer when a clock source was not
> detected (instead of falling back to a static clock)," is wrong.

Yes, the changelog's description is likely wrong about the behaviour
changing here.

Attachment: signature.asc
Description: PGP signature