Re: [PATCH 6/6] sched/topology: Remove SMT/asym capacity warning

From: Andrea Righi

Date: Tue Apr 28 2026 - 01:54:21 EST


On Tue, Apr 28, 2026 at 10:58:05AM +0530, K Prateek Nayak wrote:
> Hello Andrea,
>
> On 4/28/2026 10:46 AM, Andrea Righi wrote:
> > @@ -1732,10 +1732,6 @@ sd_init(struct sched_domain_topology_level *tl,
> > .name = tl->name,
> > };
> >
> > - WARN_ONCE((sd->flags & (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY)) ==
> > - (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY),
> > - "CPU capacity asymmetry not supported on SMT\n");
> > -
>
> Wait! Doesn't this mean we have ASYM_CAPACITY between the SMT siblings?
> That seems wrong since we expect the siblings of cores to have the same
> capacity.
>
> Have you tripped this warning during your testing?

Hm... I think you're right, I may have seen this only in a VM, let me double
check.

-Andrea