Re: [PATCH sched_ext/for-7.2] sched_ext: Collect ext_*.c include headers in build_policy.c

[Andrea Righi]

Hi Tejun,

On Mon, Apr 27, 2026 at 12:26:55AM -1000, Tejun Heo wrote:
> Move <linux/btf_ids.h> from ext.c and "ext_idle.h" from ext.c (plus its
> self-include in ext_idle.c) into build_policy.c. Subsequent patches add
> their headers the same way for consistency.
> 
> No functional change.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>

Looks good.

Reviewed-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks,
-Andrea

> ---
>  kernel/sched/build_policy.c | 2 ++
>  kernel/sched/ext.c          | 2 --
>  kernel/sched/ext_idle.c     | 1 -
>  3 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/sched/build_policy.c b/kernel/sched/build_policy.c
> index 755883faf751..ffb386889218 100644
> --- a/kernel/sched/build_policy.c
> +++ b/kernel/sched/build_policy.c
> @@ -58,7 +58,9 @@
>  #include "deadline.c"
> 
>  #ifdef CONFIG_SCHED_CLASS_EXT
> +# include <linux/btf_ids.h>
>  # include "ext_internal.h"
> +# include "ext_idle.h"
>  # include "ext.c"
>  # include "ext_idle.c"
>  #endif
> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index f7b1b16e81a5..11893f00be06 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -6,8 +6,6 @@
>   * Copyright (c) 2022 Tejun Heo <tj@xxxxxxxxxx>
>   * Copyright (c) 2022 David Vernet <dvernet@xxxxxxxx>
>   */
> -#include <linux/btf_ids.h>
> -#include "ext_idle.h"
> 
>  static DEFINE_RAW_SPINLOCK(scx_sched_lock);
> 
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 7468560a6d80..f0f4d9500997 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -9,7 +9,6 @@
>   * Copyright (c) 2022 David Vernet <dvernet@xxxxxxxx>
>   * Copyright (c) 2024 Andrea Righi <arighi@xxxxxxxxxx>
>   */
> -#include "ext_idle.h"
> 
>  /* Enable/disable built-in idle CPU selection policy */
>  static DEFINE_STATIC_KEY_FALSE(scx_builtin_idle_enabled);
> --
> 2.53.0
>