Re: [PATCH v1 1/1] ASoC: Intel: cht_bsw_rt5672: Drop unneeded NULL checks

From: Mark Brown

Date: Tue Apr 28 2026 - 04:54:42 EST


On Tue, Apr 28, 2026 at 11:16:56AM +0300, Andy Shevchenko wrote:
> On Tue, Apr 28, 2026 at 05:07:39PM +0900, Mark Brown wrote:

> > There's also the fact that as part of support for optional clocks the
> > clock API will quite happily consume NULL clocks.

> This clock is not optional, it's always retrieved with devm_clk_get().
> When the flow runs into these code pieces the mclk != NULL, and always
> valid (excluding some unrelated to this driver strange data corruption cases,
> of course).

> But yes, the CCF APIs are NULL-aware for a long time.

My point is that it makes no difference if the caller does the NULL
check.

Attachment: signature.asc
Description: PGP signature