Re: [PATCH] mm/huge_memory: Fix outdated comment about freeing subpages in __folio_split

From: David Hildenbrand (Arm)

Date: Tue Apr 28 2026 - 06:23:07 EST


On 4/28/26 12:05, Barry Song wrote:
> On Mon, Apr 27, 2026 at 3:42 PM David Hildenbrand (Arm)
> <david@xxxxxxxxxx> wrote:
>>
>> On 4/26/26 22:42, Barry Song wrote:
>>> On Thu, Apr 23, 2026 at 8:36 PM David Hildenbrand (Arm)
>>> <david@xxxxxxxxxx> wrote:
>>>
>>> Thanks, david! would it make more sense to add “when
>>> CONFIG_PAGE_MAPCOUNT is enabled” at the end of the
>>> sentence?
>>
>> Better to phrase it in a way that doesn't even require these details :)
>>
>> Do we even need this detail in the patch description?
>
> What about:
>
> The comment appears to be outdated. add_to_swap() no longer exists,
> and the explanation of why we need to call put_page() after
> splitting could be made more general.

Jup :)

--
Cheers,

David