Re: [PATCH] sh: fix fallout from ZERO_PAGE consolidation
From: Geert Uytterhoeven
Date: Tue Apr 28 2026 - 09:16:46 EST
Hi Mike,
On Fri, 17 Apr 2026 at 21:16, Mike Rapoport <rppt@xxxxxxxxxx> wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>
>
> Consolidation of empty_zero_page declarations broke boot on sh.
>
> sh stores its initial boot parameters in a page reserved in
> arch/sh/kernel/head_32.S. Before commit 6215d9f4470f ("arch, mm:
> consolidate empty_zero_page") this page was referenced in C code as an
> array and after that commit it is referenced as a pointer.
>
> This causes wrong code generation and boot hang.
>
> Declare boot_params_page as an array to fix the issue.
>
> Reported-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Tested-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page")
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
Thanks, this fixes booting on Landisk and QEMU rts7751r2d.
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds