Re: [PATCH] platform/x86: thinkpad_acpi: Add sysfs to display HWDD raw

[Mark Pearson]

On Tue, Apr 28, 2026, at 9:00 AM, Ilpo Järvinen wrote:
> On Tue, 28 Apr 2026, Mark Pearson wrote:
>
>> The Lenovo diagnostics and support team have requested a mechanism
>> to get the raw data from the HWDD commands to support customer debug
>> situations.
>> 
>> Add a sysfs entry to display the raw data.
>> 
>> As it shouldn't be needed in normal operation, add a hwdd_raw_enable
>> module parameter for when it is needed
>
> Wouldn't debugfs be more appropriate for things like this? By using it, 
> you can avoid adding the module parameter as well.
>
Yeah - you're right. I was thinking of what we did on think-lmi and didn't think of that.
I'll revisit this.

Thanks for the quick review :)
Mark