Re: [PATCH] drm/msm: Don't use UTS_RELEASE directly

[Akhil P Oommen]

On 4/28/2026 8:15 PM, Uwe Kleine-König (The Capable Hub) wrote:
> UTS_RELEASE evaluates to a static string and changes quite easily (e.g.
> uncommitted changes in the source tree or new commits). So when checking
> if a patch introduces changes to the resulting binary each usage of
> UTS_RELEASE is source of annoyance.
> 
> Instead of using UTS_RELEASE directly use init_utsname()->release which
> evaluates to the same string but with that a change of UTS_RELEASE
> doesn't affect msm_disp_snapshot_util.o or msm_gpu.o.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Reviewed-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxxxx>

-Akhil.

> ---
>  drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 4 ++--
>  drivers/gpu/drm/msm/msm_gpu.c                     | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> index 427d3ee2b833..c6eda3cf2e62 100644
> --- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> +++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> @@ -5,7 +5,7 @@
>  
>  #define pr_fmt(fmt)	"[drm:%s:%d] " fmt, __func__, __LINE__
>  
> -#include <generated/utsrelease.h>
> +#include <linux/utsname.h>
>  
>  #include "msm_disp_snapshot.h"
>  
> @@ -79,7 +79,7 @@ void msm_disp_state_print(struct msm_disp_state *state, struct drm_printer *p)
>  	}
>  
>  	drm_printf(p, "---\n");
> -	drm_printf(p, "kernel: " UTS_RELEASE "\n");
> +	drm_printf(p, "kernel: %s\n", init_utsname()->release);
>  	drm_printf(p, "module: " KBUILD_MODNAME "\n");
>  	drm_printf(p, "dpu devcoredump\n");
>  	drm_printf(p, "time: %ptSp\n", &state->time);
> diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
> index 930e54d1b0a7..3f3925b11eea 100644
> --- a/drivers/gpu/drm/msm/msm_gpu.c
> +++ b/drivers/gpu/drm/msm/msm_gpu.c
> @@ -13,11 +13,11 @@
>  #include "msm_gpu_trace.h"
>  //#include "adreno/adreno_gpu.h"
>  
> -#include <generated/utsrelease.h>
>  #include <linux/string_helpers.h>
>  #include <linux/devcoredump.h>
>  #include <linux/sched/task.h>
>  #include <linux/sched/mm.h>
> +#include <linux/utsname.h>
>  
>  /*
>   * Power Management:
> @@ -196,7 +196,7 @@ static ssize_t msm_gpu_devcoredump_read(char *buffer, loff_t offset,
>  	p = drm_coredump_printer(&iter);
>  
>  	drm_printf(&p, "---\n");
> -	drm_printf(&p, "kernel: " UTS_RELEASE "\n");
> +	drm_printf(&p, "kernel: %s\n", init_utsname()->release);
>  	drm_printf(&p, "module: " KBUILD_MODNAME "\n");
>  	drm_printf(&p, "time: %ptSp\n", &state->time);
>  	if (state->comm)
> 
> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731