Re: [PATCH net-next 2/4] r8152: Add support for the RTL8159 chip

[Birger Koblitz]

Hi Andrew,
thanks for reviewing!
On 29/04/2026 3:52 am, Andrew Lunn wrote:
> > +	case RTL_VER_17:
> >   	case RTL_VER_16:
> >   		ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_CR, CR_RE | CR_TE);
>
> nitpick. The other switch statements seem to be sorted. So 17 should
> be after 16.
Will fix in the next version.

> > +		sram_write_w0w1(tp, 0x81b9, 0xff00, 0xb900);
> > +		//nomal link TX filter
>
> normal? Please also add a space after the //. netdev also prefers /*
> */.
Will fix.

> > +		sram2_write_w0w1(tp, 0x84b2, 0xff00, 0x6000);
> > +		//Training AAGC PAR (with uc2 patch)
>
> space
Will fix.

> > +	if (tp->version == RTL_VER_17 && r8159_wait_backup_restore(tp))
> > +		return;
>
> You should probably do something with the return value from
> r8159_wait_backup_restore(). At minimum a dev_err().
I will add a dev_err() message.

Birger